fix(debug): Adds class name to ProviderException for more detailed er…

…ror logging. (#174)
spinnaker · Apr 25, 2017 · 5bd3d74 · 5bd3d74
1 parent e5d9630
commit 5bd3d74
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 14 deletions.
diff --git a/fiat-roles/src/main/java/com/netflix/spinnaker/fiat/providers/BaseProvider.java b/fiat-roles/src/main/java/com/netflix/spinnaker/fiat/providers/BaseProvider.java
@@ -72,7 +72,7 @@ public Set<R> getAll() throws ProviderException {
     try {
       return ImmutableSet.copyOf(cache.get(CACHE_KEY, this::loadAll));
     } catch (ExecutionException | UncheckedExecutionException e) {
-      throw new ProviderException(e.getCause());
+      throw new ProviderException(this.getClass(), e.getCause());
     }
   }
 

diff --git a/fiat-roles/src/main/java/com/netflix/spinnaker/fiat/providers/ProviderException.java b/fiat-roles/src/main/java/com/netflix/spinnaker/fiat/providers/ProviderException.java
@@ -18,22 +18,15 @@
 
 public class ProviderException extends RuntimeException {
 
-  public ProviderException() {
-  }
-
-  public ProviderException(String message) {
-    super(message);
-  }
-
-  public ProviderException(String message, Throwable cause) {
-    super(message, cause);
-  }
+  private Class provider;
 
-  public ProviderException(Throwable cause) {
+  public ProviderException(Class provider, Throwable cause) {
     super(cause);
+    this.provider = provider;
   }
 
-  public ProviderException(String message, Throwable cause, boolean enableSuppression, boolean writableStackTrace) {
-    super(message, cause, enableSuppression, writableStackTrace);
+  @Override
+  public String getMessage() {
+    return "(Provider: " + provider.getSimpleName() + ") " + super.getMessage();
   }
 }