Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop python 3.7 #1199

Closed
wants to merge 2 commits into from
Closed

Drop python 3.7 #1199

wants to merge 2 commits into from

Conversation

azmeuk
Copy link
Contributor

@azmeuk azmeuk commented Jul 27, 2023

Python 3.7 reached end of life on 27 Jun 2023. This PR removes tests for python 3.7, updates the documentation to reflect the new minimum python version. I also applied pyupgrade to automatically update the codebase to a more recent syntax: find ihatemoney conf ihatemoney -name "*.py" -exec pyupgrade --py38-plus "{}" +.

@zorun
Copy link
Collaborator

zorun commented Jul 27, 2023

As usual, NACK for me, at least for as long as Debian buster is supported, and probably even more. That's at least June 2024: https://wiki.debian.org/LTS

Even then, I would need good arguments why supporting Python 3.7 is preventing us from doing something.

People don't necessarily update their server OS very often, and we have to think of downstream packaging such as in Yunohost.

I'll leave this open in case @Glandos @almet want to chime in.

@azmeuk
Copy link
Contributor Author

azmeuk commented Jul 27, 2023

As usual, NACK for me, at least for as long as Debian buster is supported, and probably even more.

This is a good point. I did not realized that some supported debian would ship some eol python.

@almet
Copy link
Member

almet commented Jul 28, 2023

I share the concerns with @zorun on this. I'm closing, hope it's okay for you @azmeuk

@almet almet closed this Jul 28, 2023
@azmeuk azmeuk deleted the py37-eol branch July 28, 2023 15:45
@azmeuk
Copy link
Contributor Author

azmeuk commented Jul 28, 2023

No problem I totally understand 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants