unit test assertion fixes #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azmeuk
commented
Jul 28, 2023
`self.assertTrue(200, resp.status_code)` style are always True and thus are useless. It looks like the original author wanted `self.assertEqual` there instead.
|
Haha, you're right, and I'm probably the one who introduced this a few years back. Thanks for the changes. |
|
Good catch! That's actually a good argument in favour of pytest-style plain asserts... |
TomRoussel
pushed a commit
to TomRoussel/ihatemoney
that referenced
this pull request
Mar 2, 2024
`self.assertTrue(200, resp.status_code)` style are always True and thus are useless. It looks like the original author wanted `self.assertEqual` there instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Playing with the pytest branch I found that there were occurences of
self.assertTrue(200, resp.status_code)style assertions in the tests. This really looks like someone intended to writeself.assertEqualinstead, as testing that any number is True will always pass 🙈