Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a button to load config from notebook, rather than silently overwritting settings. #40

Draft
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

tomprince
Copy link
Contributor

@tomprince tomprince commented Feb 22, 2021

There are a couple of things I would like to improve before landing:

  • Better handling of picking spirits (so that you can see what is being applied, without being locked into spirits).
  • Better timing of the broadcast for board placement (maybe this can be handled by adding the spirit placards to the mod).

Also, I'm not sure if the place I put the button is best from a UI design.

This is #36 rebased on the rewritten commits.

@tomprince
Copy link
Contributor Author

There used to be a button a while back, but that was later removed to be in it's current iteration. Both MJ and I felt the button was unnecessary

Note that this is (I think) different that the original implementation (I think). That had a toggle for whether to load the data. This instead loads the data immediately when you click the button, letting the settings be visible and changeable.

@iakona
Copy link
Contributor

iakona commented Feb 22, 2021

What if instead of a button it auto loads the settings in? Just setup a timer that will periodically check the notebook tab?

@tomprince
Copy link
Contributor Author

I do think that overwritting settings automatically is not user friendly. Whether you do it when you press start, or on a timer.

@tomprince
Copy link
Contributor Author

What if instead of a button it auto loads the settings in? Just setup a timer that will periodically check the notebook tab?

Thinking about this further, my objection is only if a player has made any change to a config. So if we tracked if any changes have been made, and only loaded automatically if there were none, and then had a button to load otherwise, I think that would be be reasonable.

@tomprince
Copy link
Contributor Author

(filed https://tabletopsimulator.nolt.io/573 to get an event, so we wouldn't need to poll)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants