Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the spirit emblems next to the appropriate board, when specified in the json config. #68

Draft
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

tomprince
Copy link
Contributor

This takes data of the form

{
  "...": "...",
  "boards": [
    {"board": "A", "spirit": "Shadows Flicker Like Flame"},
    {"board": "D", "spirit": "Lightning's Swift Strike"}
  ],
  "...": "...",
}

and places the spirit emblems from #66 next to the corresponding board.

I'm not entirely happy with the data format, though; particularly as it duplicates the spirit names. I'm probably inclined to change the spirit dict to an array, and have it match the order of boards.

@tomprince tomprince requested a review from iakona March 10, 2021 04:16
@iakona
Copy link
Contributor

iakona commented Mar 10, 2021

while a bit more fragile in nature i'd prefer having the boards and spirits requiring to match the same order to cut down on redundancy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants