Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote values in SQL query #239

Closed
wants to merge 3 commits into from
Closed

Quote values in SQL query #239

wants to merge 3 commits into from

Conversation

annda
Copy link
Contributor

@annda annda commented Jan 24, 2024

Fixes regression introduced in refactoring for the new SQLite class

Fixes dokuwiki/dokuwiki#4152

Fixes regression introduced in refactoring for the new SQLite class
@annda
Copy link
Contributor Author

annda commented Jan 25, 2024

Tests run fine after the latest update of the sqlite plugin.

There are still 68 code style violations to fix manually...

@annda annda marked this pull request as draft January 25, 2024 16:23
@annda
Copy link
Contributor Author

annda commented Jan 29, 2024

The actual issue that this PR is supposed to fix is already addressed in the latest version of the data plugin.

I am closing this PR and will open another one with updated testing workflow and code style fixes.

@annda annda closed this Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempt to sort Table "DokuWiki Installations" causes error Message
1 participant