Merge branch 'feat/spike-poc-dashboard-side-panel' of https://github.…

…com/splunk/addonfactory-ucc-generator into feat/spike-poc-dashboard-side-panel
splunk · Oct 7, 2024 · 08362cb · 08362cb
2 parents 712cc27 + b7b1a27
commit 08362cb
Show file tree

Hide file tree

Showing 8 changed files with 188 additions and 488 deletions.
diff --git a/NOTICE b/NOTICE
diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md
@@ -1,3 +1,10 @@
+## [5.50.1](https://github.com/splunk/addonfactory-ucc-generator/compare/v5.50.0...v5.50.1) (2024-10-04)
+
+
+### Bug Fixes
+
+* use title for app conf ([#1356](https://github.com/splunk/addonfactory-ucc-generator/issues/1356)) ([adfd987](https://github.com/splunk/addonfactory-ucc-generator/commit/adfd9879832b66cd6749fb530bf575ad1a18d053))
+
 # [5.50.0](https://github.com/splunk/addonfactory-ucc-generator/compare/v5.49.0...v5.50.0) (2024-10-02)
 
 

diff --git a/pyproject.toml b/pyproject.toml
@@ -16,7 +16,7 @@
 
 [tool.poetry]
 name = "splunk_add_on_ucc_framework"
-version = "5.50.0"
+version = "5.50.1"
 description = "Splunk Add-on SDK formerly UCC is a build and code generation framework"
 license = "Apache-2.0"
 authors = ["Splunk <[email protected]>"]

diff --git a/splunk_add_on_ucc_framework/__init__.py b/splunk_add_on_ucc_framework/__init__.py
@@ -13,7 +13,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 #
-__version__ = "5.50.0"
+__version__ = "5.50.1"
 
 import logging
 

diff --git a/splunk_add_on_ucc_framework/generators/conf_files/create_app_conf.py b/splunk_add_on_ucc_framework/generators/conf_files/create_app_conf.py
@@ -47,6 +47,7 @@ def _set_attributes(self, **kwargs: Any) -> None:
         self.addon_version = kwargs["addon_version"]
         self.is_visible = str(kwargs["has_ui"]).lower()
         self.description = kwargs["app_manifest"].get_description()
+        self.title = kwargs["app_manifest"].get_title()
         self.author = kwargs["app_manifest"].get_authors()[0]["name"]
         self.build = str(int(time()))
 
@@ -65,7 +66,7 @@ def generate_conf(self) -> Dict[str, str]:
             name=self.name,
             build=self.build,
             id=self.id,
-            label=self.description,
+            label=self.title,
             is_visible=self.is_visible,
         )
         self.writer(

diff --git a/...ted_addons/expected_output_global_config_everything/Splunk_TA_UCCExample/default/app.conf b/...ted_addons/expected_output_global_config_everything/Splunk_TA_UCCExample/default/app.conf
@@ -6,11 +6,11 @@ state = enabled
 [launcher]
 author = Splunk Inc.
 version = 5.5.8R5fd76615
-description = Splunk Add-on for UCC Example
+description = Some description of Splunk Add-on for UCC Example
 
 [ui]
 is_visible = true
-label = Splunk Add-on for UCC Example
+label = Title of Splunk Add-on for UCC Example
 supported_themes = light, dark
 
 [package]

diff --git a/tests/testdata/test_addons/package_global_config_everything/globalConfig.json b/tests/testdata/test_addons/package_global_config_everything/globalConfig.json
@@ -1622,10 +1622,10 @@
     "meta": {
         "name": "Splunk_TA_UCCExample",
         "restRoot": "splunk_ta_uccexample",
-        "version": "5.49.0Rcc63ee532",
+        "version": "5.50.0R6465f0b6a",
         "displayName": "Splunk UCC test Add-on",
         "schemaVersion": "0.0.8",
-        "_uccVersion": "5.49.0",
+        "_uccVersion": "5.50.0",
         "supportedThemes": [
             "light",
             "dark"

diff --git a/tests/testdata/test_addons/package_global_config_everything/package/app.manifest b/tests/testdata/test_addons/package_global_config_everything/package/app.manifest
@@ -1,7 +1,7 @@
 {
   "schemaVersion": "2.0.0",
   "info": {
-    "title": "Splunk Add-on for UCC Example",
+    "title": "Title of Splunk Add-on for UCC Example",
     "id": {
       "group": null,
       "name": "Splunk_TA_UCCExample",
@@ -15,7 +15,7 @@
       }
     ],
     "releaseDate": null,
-    "description": "Splunk Add-on for UCC Example",
+    "description": "Some description of Splunk Add-on for UCC Example",
     "classification": {
       "intendedAudience": null,
       "categories": [],