-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: extract alert entity (#1377)
**Issue number:[ADDON-73358](https://splunk.atlassian.net/browse/ADDON-73358)** ## Summary Alerts used to have only one entity and were created using the same schema where the type was based on the enum. Additional validation of whether a given parameter for a specific enum is correct was done on the backend. Now each entity has its own definition and no additional validation is needed on BE. ### Changes Extracted AlertsEntity into 6 schemas, one for each enum. Removed BE validation for required parameters. ### User experience No impact ## Checklist If your change doesn't seem to apply, please leave them unchecked. * [x] I have performed a self-review of this change * [x] Changes have been tested * [ ] Changes are documented * [x] PR title follows [conventional commit semantics](https://www.conventionalcommits.org/en/v1.0.0/)
- Loading branch information
1 parent
ef3b6a9
commit 139a47a
Showing
2 changed files
with
229 additions
and
50 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters