-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modal implementation for data ingestion table #1244
Conversation
…com/splunk/addonfactory-ucc-generator into feat/spike-poc-dashboard-side-panel
@rohanm-crest as there was data_ingestion_modal_definition.json created, there is also a need to adjust smoke tests accordingly
instead of current
lets make sure pipelines passed and i will than check all of it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a small thing i found after brief look
some ideas regarding selector inside modal,
inside payload there are all data from table, thanks to that we can have all inputs from first column and add it into selector, Also it would be nice to have a separated selector (from definition.json) as we need to change json definition based on selector change) , if user clicks testInput2 we need to adjust search queries,
pros: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also lets remember to not marge it untill we align all dynamics part into this PR.
…com/splunk/addonfactory-ucc-generator into feat/spike-poc-dashboard-side-panel
…com/splunk/addonfactory-ucc-generator into feat/spike-poc-dashboard-side-panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments left
Also a question can we render dashboard components faster, as currently i believe we display dashboard panels after we get all data for drop down, but we should be displaying all at once and if anything goes wrong just hide drop down with inputs
…com/splunk/addonfactory-ucc-generator into feat/spike-poc-dashboard-side-panel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all looks good except that line
https://github.com/splunk/addonfactory-ucc-generator/pull/1244/files#diff-1eb337cab3b2550b4dec3115308f2f424bf6fb4c614683016fa667efc5a6e734R20
seems like when we remove it we have errors that shouldn't occur, but due to i wasn't a ble to reproduce it on real environment and that PR is here for long time i would say lets merge it and fix that one in next branch
Issue number: ADDON-70993, ADDON-72969
Summary
Changes
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.