feat: allow validators for oauth fields #1355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsvetkov-splunk
previously approved these changes
Oct 3, 2024
soleksy-splunk
force-pushed
the
feat/support-validators-for-oauth-fields
branch
2 times, most recently
from
13c35b0
to
f51fdbe
Compare
artemrys
reviewed
Oct 8, 2024
|
Can we add UI SmartX test case to capture this behaviour? |
soleksy-splunk
force-pushed
the
feat/support-validators-for-oauth-fields
branch
from
f51fdbe
to
67db697
Compare
soleksy-splunk
force-pushed
the
feat/support-validators-for-oauth-fields
branch
from
ab7134d
to
5fb1d0d
Compare
vtsvetkov-splunk
approved these changes
Oct 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
https://splunk.atlassian.net/browse/ADDON-61740
Summary
allows validators to oauth fields
Changes
allow validators array inside globalConfig.json scheme
User experience
right now oauth fields can be validated
Checklist
If your change doesn't seem to apply, please leave them unchecked.