Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use title for app conf #1356

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

soleksy-splunk
Copy link
Contributor

@soleksy-splunk soleksy-splunk commented Oct 3, 2024

Issue number:
https://splunk.atlassian.net/browse/ADDON-75546

Summary

description was used instead of title, wrong text was displayed

Changes

change description into title

Please provide a summary of what's being changed

User experience

Title correctly displayed

Please describe what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

@soleksy-splunk soleksy-splunk requested a review from a team as a code owner October 3, 2024 16:51
sgoral-splunk
sgoral-splunk previously approved these changes Oct 4, 2024
@sgoral-splunk
Copy link
Contributor

approved as this is a fix, but we should add some tests to cover that change

kkedziak-splunk
kkedziak-splunk previously approved these changes Oct 4, 2024
@sgoral-splunk sgoral-splunk dismissed stale reviews from kkedziak-splunk and themself via f4d12ec October 4, 2024 08:37
@soleksy-splunk soleksy-splunk merged commit adfd987 into develop Oct 4, 2024
76 of 77 checks passed
@soleksy-splunk soleksy-splunk deleted the fix-use-title-for-label-in-ui-app-conf branch October 4, 2024 09:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants