feat: add checks for the appropriate splunktaucclib version #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
sgoral-splunk
force-pushed
the
feat/add_splunktaucclib_version_check
branch
from
447a629
to
70bf755
Compare
lplonka-splunk
previously approved these changes
Oct 15, 2024
artemrys
requested changes
Oct 15, 2024
Comment on lines
166
to
168
| raise SplunktaucclibNotFound( | ||
| f"splunktaucclib is not found in {path_to_requirements_file}. " | ||
| f"Please add it there because this add-on has UI." | ||
| f"splunktaucclib is not found in {path_to_requirements_file} or has invalid version. " | ||
| f"Please add it there and check if it is at least version 6.4, because this add-on has UI." |
There was a problem hiding this comment.
I would suggest to separate this into 2 different exceptions / messages:
- there is no
splunktaucclibfound but this add-ons has UI splunktaucclibfound but the developer needs to update it to the version we specify because of
I think it would be easier to understand why build does not actually work.
| @@ -55,6 +61,24 @@ def _subprocess_call( | |||
| raise e | |||
|
|
|||
|
|
|||
| def _subprocess_run( | |||
There was a problem hiding this comment.
This looks very similar to _subprocess_call. I would suggest refactoring _subprocess_call into returning full response and using it everywhere.
|
I think that's a |
sgoral-splunk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:ADDON-74237
Summary
Added splunktaucclib version checking.
Changes
User experience
The build process will be canceled if an incorrect version of the splunktaucclib library is used.
Checklist
If your change doesn't seem to apply, please leave them unchecked.