chore: fix use instance_type instead of product_type #1378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtsvetkov-splunk
previously approved these changes
Oct 15, 2024
vtsvetkov-splunk
approved these changes
Oct 15, 2024
soleksy-splunk
deleted the
chore--use-instance_type-for-element-hiding
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
https://splunk.atlassian.net/browse/ADDON-74887
Summary
changing verifying product_type into verifying instance_type
product_type got value enterprise even for cloud
instance_type is used to determine cloud (does not appear for enterprise)
Changes
use correct prop
User experience
none
Checklist
If your change doesn't seem to apply, please leave them unchecked.