fix(validation): correctly validate empty not required data #1606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soleksy-splunk
changed the title
|
should we link this? |
yea lets link it. |
vtsvetkov-splunk
previously approved these changes
Feb 28, 2025
ui/src/util/tests/validators.test.ts
Outdated
| @@ -210,6 +212,29 @@ describe('Validator.doValidation - number case', () => { | |||
| expect(result).toBe(false); | |||
| }); | |||
|
|
|||
| it.each([undefined, null])( | |||
There was a problem hiding this comment.
is it possible that data === ''?
There was a problem hiding this comment.
for the number no. But i actually created a test for it just in case in a separate PR
Co-authored-by: Viktor Tsvetkov <[email protected]>
vtsvetkov-splunk
previously approved these changes
Feb 28, 2025
9 tasks
vtsvetkov-splunk
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
https://splunk.atlassian.net/browse/ADDON-78393
PR Type
What kind of change does this PR introduce?
Summary
Changes
N/A do not throw error if number undefined and not required.
User experience
When copying entity right now correctly verify number value.
Checklist
If an item doesn't apply to your changes, leave it unchecked.