Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring for formatting and some logical error correction #308

Conversation

cmcginley-splunk
Copy link
Collaborator

@cmcginley-splunk cmcginley-splunk commented Oct 15, 2024

Context

Code Changes

  • there was a small logical error in CorrelationSearch with these changes (made into a property bet we still tried to set it later); fixed
  • additionally made some formatting changes

@cmcginley-splunk cmcginley-splunk changed the title refactoring for formatting and some logical error correction Refactoring for formatting and some logical error correction Oct 15, 2024
@cmcginley-splunk cmcginley-splunk marked this pull request as ready for review October 15, 2024 21:21
Copy link
Contributor

@pyth0n1c pyth0n1c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve these changes. This PR will be merged into its target, then that PR will be merged into main branch.

contentctl/objects/correlation_search.py Show resolved Hide resolved
@pyth0n1c pyth0n1c merged commit d3e063a into mathieugonzales_replace_deprecated_pydantic_validators Oct 15, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants