fix: update splunksplwrapper dep where it retries service init #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #790 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 51 51
Lines 2763 2763
=======================================
Hits 2397 2397
Misses 366 366 |
mbruzda-splunk
force-pushed
the
fix/retry_service
branch
from
29d06eb
to
e739b49
Compare
artemrys
approved these changes
Jul 25, 2023
srv-rr-github-token
added a commit
that referenced
this pull request
Jul 25, 2023
## [5.0.2](v5.0.1...v5.0.2) (2023-07-25) ### Bug Fixes * update splunksplwrapper dep where it retries service init ([#790](#790)) ([99c6594](99c6594))
|
🎉 This PR is included in version 5.0.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PSA sometimes throws an error "Temporary failure in name resolution" which makes some tests to fail which results in a retry which takes time and is not reliable.
The specific log can be found here: https://github.com/splunk/splunk-add-on-for-cisco-asa/actions/runs/4627279372/job/12563451275
PSA uses splunksplwrapper (helmut) to make requests to Splunk itself, so the fix for this problem is to improve that library. The merged fix can be found here. It makes splunksplwrapper to retry failed requests up to 3 times with 5 seconds delay. This should increase the reliability of the tests.