-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit-Testing using contentctl #3028
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this looks good. After it is merged, we should do some stress-testing where we open a PR from an external (non splunk/security_content member) repo to ensure that the mode:changes functionality works from external forks as well.
.github/workflows/build.yml
Outdated
@@ -23,29 +21,20 @@ jobs: | |||
run: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this workflow needs jq (anymore) can it be removed entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed!
.github/workflows/unit-testing.yml
Outdated
|
||
- name: Install System Packages and contentctl | ||
run: | | ||
sudo apt update -qq |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we are doing the processing with python i think we can remove jq?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
This workflow was also tested on PR from Dean Luxton (Splunker) and it seemed to have worked correctly! You can check the run here : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed workflow and results. Looks great! Approved!
This PR enables Unit-testing in Github Actions CI using contentctl.
Additionally added a script to pretty print the pass/failures of detections from summary.yml