Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical Alerts detection - Microsoft Defender #3058

Merged
merged 89 commits into from
Oct 15, 2024

Conversation

gowthamarajr
Copy link
Contributor

@gowthamarajr gowthamarajr commented Jul 25, 2024

Details

Detection - Detect Critical Alerts from Security Tools
Story - Critical Alerts

Checklist

  • Validate name matches <platform>_<mitre att&ck technique>_<short description> nomenclature
  • CI/CD jobs passed ✔️
  • Validated SPL logic.
  • Validated tags, description, and how to implement.
  • Verified references match analytic.
  • Confirm updates to lookups are handled properly.

Notes For Submitters and Reviewers

  • If you're submitting a PR from a fork, ensuring the box to allow updates from maintainers is checked will help speed up the process of getting it merged.
  • Checking the output of the build CI job when it fails will likely show an error about what is failing. You may have a very descriptive error of the specific field(s) in the specific file(s) that is causing an issue. In some cases, its also possible there is an issue with the YAML. Many of these can be caught with the pre-commit hooks if you set them up. These errors will be less descriptive as to what exactly is wrong, but will give you a column and row position in a specific file where the YAML processing breaks. If you're having trouble with this, feel free to add a comment to your PR tagging one of the maintainers and we'll be happy to help troubleshoot it.
  • Updates to existing lookup files can be tricky, because of how Splunk handles application updates and the differences between existing lookup files being updated vs new lookups. You can read more here but the short version is that any changes to lookup files need to bump the datestamp in the lookup CSV filename, and the reference to it in the YAML needs to be updated.

@patel-bhavin patel-bhavin changed the title Add critical alerts to risk index Critical Alerts detection - Microsoft Defender Oct 9, 2024
@patel-bhavin patel-bhavin added this to the v4.41.0 milestone Oct 10, 2024
@patel-bhavin patel-bhavin removed this from the v4.41.0 milestone Oct 11, 2024
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small things

contentctl.yml Show resolved Hide resolved
data_sources/windows_defender_alerts.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@ljstella ljstella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

:shipit:

@patel-bhavin
Copy link
Contributor

Known CI Error . the other jobs look good!

@patel-bhavin patel-bhavin merged commit 0581a09 into develop Oct 15, 2024
5 of 8 checks passed
@patel-bhavin patel-bhavin deleted the correlation_search_risk_index branch October 15, 2024 21:35
@patel-bhavin patel-bhavin added this to the v4.43.0 milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants