Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A couple bug fixes #288

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

A couple bug fixes #288

wants to merge 8 commits into from

Conversation

Swanty
Copy link

@Swanty Swanty commented Jul 21, 2024

This pull request fixes a couple bugs - separated each fix in their own commit

@Swanty Swanty requested a review from spnda as a code owner July 21, 2024 08:54
@Swanty Swanty force-pushed the bug-fixes-20240721 branch from 02af1b3 to 295ab93 Compare July 23, 2024 07:20
@Swanty Swanty marked this pull request as draft July 23, 2024 07:43
@Swanty
Copy link
Author

Swanty commented Jul 23, 2024

Converting to draft and will let it marinate on my server, since some fixes introduced new bugs (fixed them, but there might be more)

@spnda
Copy link
Owner

spnda commented Aug 6, 2024

Do you have any updates regarding this? Otherwise I'd cherry-pick some of these in the coming days.

@Ablaze647
Copy link

Ablaze647 commented Aug 7, 2024

Do you have any updates regarding this? Otherwise I'd cherry-pick some of these in the coming days.

So far haven't noticed anything else broken with the basic functionality of adding/removing friends, setting friend as read only or read/write.

Though setting a friend as a Manager is kinda broken, didn't test it much, but if a Manager opens Redstone settings menu and then closes the menu - all redstone settings become disabled

Probably best to cherry-pick yeah

EDIT: Oh oops, commented from my other GitHub account...awkward xD

Copy link

stale bot commented Nov 7, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue that was closed due to inactivity label Nov 7, 2024
@spnda spnda added the enhancement New feature or request label Nov 7, 2024
@stale stale bot closed this Nov 16, 2024
@spnda spnda reopened this Nov 16, 2024
@spnda spnda added the pinned A pinned issue that will not be considered stale label Nov 16, 2024
@stale stale bot removed the stale A stale issue that was closed due to inactivity label Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pinned A pinned issue that will not be considered stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants