-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: glTF Exporter #33
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spnda
force-pushed
the
gltf_composing
branch
4 times, most recently
from
January 2, 2024 01:32
ee3a673
to
f1cfd62
Compare
Adds a test which goes through every single glTF in a specific folder and tests if the re-export from fastgltf is valid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
fastgltf::Exporter
object that can serialize afastgltf::Asset
into either a JSON or a binary blob (GLB).fastgltf::FileExporter
builds upon this object by also automatically writing all of the relevant data to disk.TODO list:
I'm opening this PR to keep track of the work and to have other people take their look before I push this into the main branch of the repository.
I also thought of a functional API for writing glTFs that would guarantee data safety while writing in various ways. That could, however, also be achieved by calling the
validate
function at the start ofComposer::writeGLTF
to guarantee the data is valid. Having the user properly figure out data relations from the glTF spec could still be tedious, where a functional API would be much more intuitive to use, as data relations would be much more apparent from the code itself. I will see if this additional API is necessary in the future.