forked from metaborg/spoofax-shell
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RDY] Evaluation in context with dynsem generated interpreter #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39eef21
to
3cbf567
Compare
|
||
<rule ref="rulesets/java/empty.xml/EmptyCatchBlock"> | ||
<properties> | ||
<property name="allowCommentedBlocks" value="true"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2af425c
to
75749f9
Compare
This required adding a custom unit, since our own Result class expects one.
Merged
…ronment" The shell init rule's result is now discarded, and only the initialized semantic components are used.
Some language (like the simplelanguage) need a parser at runtime
By default, if the language designer specified no transformer, getTransformer returns an identity transformer
Inject dependencies, so that I can inject a mock interpreter loader. The interpreter loader is responsible for returning a program term, as it knows where the generated classes are.
Now properly handles rules that were not found (i.e. when findGlobalSymbol returns null)
… when no sort was found
Removes the need for adding a custom ruleset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on the following PRs: