Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RDY] Evaluation in context with dynsem generated interpreter #20

Merged
merged 39 commits into from
Jun 8, 2016

Conversation

Balletie
Copy link

@Balletie Balletie commented May 24, 2016

Relies on the following PRs:

@Balletie Balletie force-pushed the eval-context branch 5 times, most recently from 39eef21 to 3cbf567 Compare June 2, 2016 14:41
@Balletie Balletie changed the title [WIP] Evaluation in context with dynsem generated interpreter [RFC] Evaluation in context with dynsem generated interpreter Jun 6, 2016

<rule ref="rulesets/java/empty.xml/EmptyCatchBlock">
<properties>
<property name="allowCommentedBlocks" value="true"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hjdskes
Copy link
Member

Hjdskes commented Jun 8, 2016

Really nice work @Balletie! Is it necessary for me / @gfokkema to review the PRs you linked to, as well? I glanced over them quickly and they look good to me.

Before we merge this, I'd like to see the build pass, too.

@gfokkema gfokkema force-pushed the eval-context branch 3 times, most recently from 2af425c to 75749f9 Compare June 8, 2016 10:07
Balletie added 2 commits June 8, 2016 13:11
This required adding a custom unit, since our own Result class expects
one.
Balletie and others added 18 commits June 8, 2016 13:53
…ronment"

The shell init rule's result is now discarded, and only the initialized semantic components are used.
Some language (like the simplelanguage) need a parser at runtime
By default, if the language designer specified no transformer, getTransformer returns an identity transformer
Inject dependencies, so that I can inject a mock interpreter loader. The interpreter loader is responsible for returning a program term, as it knows where the generated classes are.
Now properly handles rules that were not found (i.e. when findGlobalSymbol returns null)
Removes the need for adding a custom ruleset
@Hjdskes Hjdskes changed the title [RFC] Evaluation in context with dynsem generated interpreter [RDY] Evaluation in context with dynsem generated interpreter Jun 8, 2016
@Hjdskes Hjdskes merged commit d7dbe08 into master Jun 8, 2016
@Hjdskes Hjdskes deleted the eval-context branch June 8, 2016 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants