Remove negative check for `nil` #446

ashmaroli · 2021-12-10T11:50:59Z

Technically, if an object is not nil, it is either a Boolean false or a truthy.

I'm making an assumption here that false can be ignored because this check is used against values set by :parse method.
Therefore, the test for != nil is redundant.

houndci-bot · 2021-12-10T11:51:07Z

lib/addressable/uri.rb

@@ -2502,7 +2501,7 @@ def validate
      unreserved = CharacterClasses::UNRESERVED
      sub_delims = CharacterClasses::SUB_DELIMS
      if !self.host.nil? && (self.host =~ /[<>{}\/\\\?\#\@"[[:space:]]]/ ||
-          (self.host[/^\[(.*)\]$/, 1] != nil && self.host[/^\[(.*)\]$/, 1] !~
+          (self.host[/^\[(.*)\]$/, 1] && self.host[/^\[(.*)\]$/, 1] !~


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2021-12-10T11:51:07Z

lib/addressable/uri.rb

        raise InvalidURIError,
          "Cannot have a relative path with an authority set: '#{self.to_s}'"
      end
-      if self.path != nil && !self.path.empty? &&
+      if self.path && !self.path.empty? &&


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2021-12-10T11:51:07Z

lib/addressable/uri.rb

-      if self.path != nil && !self.path.empty? && self.path[0..0] != SLASH &&
-          self.authority != nil
+      if self.path && !self.path.empty? && self.path[0..0] != SLASH &&
+          self.authority


Layout/MultilineOperationIndentation: Align the operands of a condition in an if statement spanning multiple lines.
Style/RedundantSelf: Redundant self detected.

houndci-bot · 2021-12-10T11:51:07Z

lib/addressable/uri.rb

          raise InvalidURIError, "Hostname not supplied: '#{self.to_s}'"
        end
      end
-      if self.path != nil && !self.path.empty? && self.path[0..0] != SLASH &&
-          self.authority != nil
+      if self.path && !self.path.empty? && self.path[0..0] != SLASH &&


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2021-12-10T11:51:07Z

lib/addressable/uri.rb

-            self.password != nil
+        if self.port ||
+            self.user ||
+            self.password


Layout/MultilineOperationIndentation: Align the operands of a condition in an if statement spanning multiple lines.
Style/RedundantSelf: Redundant self detected.

houndci-bot · 2021-12-10T11:51:08Z

lib/addressable/uri.rb

          self.path =~ NORMPATH
        raise InvalidURIError,
          "Cannot assemble URI string with ambiguous path: '#{self.path}'"
      end
      @uri_string ||= begin
        uri_string = String.new
-        uri_string << "#{self.scheme}:" if self.scheme != nil
-        uri_string << "//#{self.authority}" if self.authority != nil
+        uri_string << "#{self.scheme}:" if self.scheme


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2021-12-10T11:51:08Z

lib/addressable/uri.rb

@@ -2359,18 +2358,18 @@ def empty?
    #
    # @return [String] The URI's <code>String</code> representation.
    def to_s
-      if self.scheme == nil && self.path != nil && !self.path.empty? &&
+      if self.scheme == nil && self.path && !self.path.empty? &&


Style/RedundantSelf: Redundant self detected.
Style/NilComparison: Prefer the use of the nil? predicate.

houndci-bot · 2021-12-10T11:51:08Z

lib/addressable/uri.rb

@@ -1971,7 +1970,7 @@ def join(uri)

              # If the base path is empty and an authority segment has been
              # defined, use a base path of SLASH
-              if base_path.empty? && self.authority != nil
+              if base_path.empty? && self.authority


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2021-12-10T11:51:08Z

lib/addressable/uri.rb

@@ -1947,7 +1946,7 @@ def join(uri)
        else
          if uri.path == nil || uri.path.empty?
            joined_path = self.path
-            if uri.query != nil
+            if uri.query


Metrics/BlockNesting: Avoid more than 3 levels of block nesting.
Style/ConditionalAssignment: Use the return of the conditional for variable assignment and comparison.

houndci-bot · 2021-12-10T11:51:09Z

lib/addressable/uri.rb

          site_string << "#{self.normalized_scheme}:"
        end
-        if self.normalized_authority != nil
+        if self.normalized_authority


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

@@ -1498,10 +1497,10 @@ def normalized_site
      return nil unless self.site
      @normalized_site ||= begin
        site_string = "".dup
-        if self.normalized_scheme != nil
+        if self.normalized_scheme


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

-        site_string << "#{self.scheme}:" if self.scheme != nil
-        site_string << "//#{self.authority}" if self.authority != nil
+        site_string << "#{self.scheme}:" if self.scheme
+        site_string << "//#{self.authority}" if self.authority


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

@@ -1479,8 +1478,8 @@ def default_port
    def site
      (self.scheme || self.authority) && @site ||= begin
        site_string = "".dup
-        site_string << "#{self.scheme}:" if self.scheme != nil
-        site_string << "//#{self.authority}" if self.authority != nil
+        site_string << "#{self.scheme}:" if self.scheme


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

-      if new_port != nil && !(new_port.to_s =~ /^\d+$/)
-        raise InvalidURIError,
-          "Invalid port number: #{new_port.inspect}"
+      if new_port && !(new_port.to_s =~ /^\d+$/)


Style/InverseMethods: Use !~ instead of inverting =~.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

@@ -1418,17 +1418,16 @@ def normalized_port
    #
    # @param [String, Integer, #to_s] new_port The new port component.
    def port=(new_port)
-      if new_port != nil && new_port.respond_to?(:to_str)
+      if new_port && new_port.respond_to?(:to_str)


Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

          authority << "#{self.normalized_userinfo}@"
        end
        authority << self.normalized_host
-        if self.normalized_port != nil
+        if self.normalized_port


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

@@ -1261,11 +1261,11 @@ def normalized_authority
      return nil unless self.authority
      @normalized_authority ||= begin
        authority = String.new
-        if self.normalized_userinfo != nil
+        if self.normalized_userinfo


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

          authority << "#{self.userinfo}@"
        end
        authority << self.host
-        if self.port != nil
+        if self.port


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

@@ -1242,11 +1242,11 @@ def domain
    def authority
      self.host && @authority ||= begin
        authority = String.new
-        if self.userinfo != nil
+        if self.userinfo


Style/RedundantSelf: Redundant self detected.

houndci-bot · 2022-01-15T12:47:44Z

lib/addressable/uri.rb

@@ -686,7 +686,7 @@ def self.normalized_encode(uri, return_type=String)
        :fragment => self.unencode_component(uri_object.fragment)
      }
      components.each do |key, value|
-        if value != nil
+        if value


Style/Next: Use next to skip iteration.

lib/addressable/uri.rb

@@ -2502,7 +2501,7 @@ def validate
      unreserved = CharacterClasses::UNRESERVED
      sub_delims = CharacterClasses::SUB_DELIMS
      if !self.host.nil? && (self.host =~ /[<>{}\/\\\?\#\@"[[:space:]]]/ ||
-          (self.host[/^\[(.*)\]$/, 1] != nil && self.host[/^\[(.*)\]$/, 1] !~
+          (self.host[/^\[(.*)\]$/, 1] && self.host[/^\[(.*)\]$/, 1] !~


dpep · 2022-12-15T21:08:51Z

nice simplifications! in a similar vein, what do you think of swapping return nil if ... for return if ... ?

Remove negative check for nil

67e72bc

houndci-bot reviewed Dec 10, 2021

View reviewed changes

Merge branch 'main' into redundant-negative-nil-check

9ead055

houndci-bot reviewed Jan 15, 2022

View reviewed changes

Janzawada57 approved these changes Mar 28, 2022

View reviewed changes

Merge branch 'main' into redundant-negative-nil-check

e9cc671

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove negative check for `nil` #446

Remove negative check for `nil` #446

ashmaroli commented Dec 10, 2021

houndci-bot Dec 10, 2021

This comment was marked as spam.

houndci-bot Dec 10, 2021

houndci-bot Dec 10, 2021

houndci-bot Dec 10, 2021

houndci-bot Dec 10, 2021

houndci-bot Dec 10, 2021

houndci-bot Dec 10, 2021

houndci-bot Dec 10, 2021

houndci-bot Dec 10, 2021

houndci-bot Dec 10, 2021

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

houndci-bot Jan 15, 2022

This comment was marked as spam.

dpep commented Dec 15, 2022

Remove negative check for nil #446

Are you sure you want to change the base?

Remove negative check for nil #446

Conversation

ashmaroli commented Dec 10, 2021

Choose a reason for hiding this comment

This comment was marked as spam.

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

This comment was marked as spam.

dpep commented Dec 15, 2022

Remove negative check for `nil` #446

Remove negative check for `nil` #446