Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rspec binstub #45

Closed
wants to merge 2 commits into from
Closed

Conversation

jasonkarns
Copy link

@jasonkarns jasonkarns commented Mar 6, 2017

Rspec test suite requires being run in context of bundle. This provides the bundler binstub necessary to do so.

Added bundler config because the default binstub location is presently used for bins provided by this gem itself, not for binstubs used by its developers.

Partially addresses #44

@jasonkarns
Copy link
Author

Just had a conversation with some other devs and apparently, there's a slightly more conventional way to solve this...

Rather than having brew-gem's bin under bin/, it should be moved to exe/. This leaves bin/ open for bundler binstubs which then eliminates the need for the .bundle/config file being committed.

Thoughts on this?

@jasonkarns
Copy link
Author

Updated PR to reflect current convention (exe for bins distributed by the gem, bin for binstubs)

@jasonkarns
Copy link
Author

bump

@anfleene anfleene closed this Oct 14, 2019
@jasonkarns jasonkarns deleted the bundle-binstub branch March 2, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants