Fixed sample code and instructions #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sporto
reviewed
Oct 3, 2017
| @@ -4,8 +4,10 @@ | |||
|
|
|||
| In the last section, we created an application using Html.program that was just static Html. Now let's create an application that responds to user interaction using messages. | |||
|
|
|||
| Now, edit your **App.elm** file, or create a new one (just remember to give the module the same name that your source file has): | |||
|
|
|||
There was a problem hiding this comment.
In https://github.com/sporto/elm-tutorial-app/blob/master/src/Main.elm I named the app Main.
I think this is great, but please change to Main.elm
There was a problem hiding this comment.
Don't mind this. You are right, this part of the tutorial uses App.elm. I might need to make this consistent later.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following the tutorial (finally learning Elm!!!), and I got a bit confused during this step. I didn't know at first whether I should create a new file or just edit App.elm. Eventually I figured it out as it's not really rocket science, but this should help newcomers 😄