Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Bump OF SDK to 0.2.2 #118

Merged
merged 1 commit into from
Jan 16, 2024
Merged

build: Bump OF SDK to 0.2.2 #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Provider/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
}

object Versions {
const val openFeatureSDK = "0.2.1"
const val openFeatureSDK = "0.2.2"
const val okHttp = "4.10.0"
const val kotlinxSerialization = "1.6.0"
const val coroutines = "1.7.3"
Expand Down
4 changes: 3 additions & 1 deletion Provider/src/main/java/com/spotify/confidence/ConfidenceFeatureProvider.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,9 @@ class ConfidenceFeatureProvider private constructor(

override fun observe(): Flow<OpenFeatureEvents> = eventHandler.observe()

override fun isProviderReady(): Boolean = eventHandler.isProviderReady()
override fun getProviderStatus(): OpenFeatureEvents {
return eventHandler.getProviderStatus()
}

override fun getBooleanEvaluation(
key: String,
Expand Down
4 changes: 2 additions & 2 deletions Provider/src/test/java/com/spotify/confidence/StorageFileCacheTests.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import dev.openfeature.sdk.ImmutableContext
import dev.openfeature.sdk.ImmutableStructure
import dev.openfeature.sdk.Reason
import dev.openfeature.sdk.Value
import dev.openfeature.sdk.async.awaitReady
import dev.openfeature.sdk.async.awaitReadyOrError
import dev.openfeature.sdk.events.EventHandler
import dev.openfeature.sdk.events.OpenFeatureEvents
import junit.framework.TestCase
Expand Down Expand Up @@ -85,7 +85,7 @@ class StorageFileCacheTests {
cache = cache1
)
provider1.initialize(ImmutableContext(targetingKey = "user1"))
provider1.awaitReady(testDispatcher)
provider1.awaitReadyOrError(testDispatcher)

// Simulate offline scenario
whenever(mockClient.resolve(eq(listOf()), any())).thenThrow(Error())
Expand Down
2 changes: 1 addition & 1 deletion Provider/src/test/java/com/spotify/confidence/TestExtensions.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ suspend fun awaitProviderReady(
fun observeProviderReady() = eventsHandler
.observe<OpenFeatureEvents.ProviderReady>()
.onStart {
if (eventsHandler.isProviderReady()) {
if (eventsHandler.getProviderStatus() == OpenFeatureEvents.ProviderReady) {
this.emit(OpenFeatureEvents.ProviderReady)
}
}
Expand Down
Loading