feat: Add observable error events in case of failed remote resolve #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
requested review from
nicklasl,
nickybondarenko and
vahidlazio
as code owners
nicklasl
force-pushed
the
expose-resolve-errors
branch
from
2c36f62 to
da8a4f4
Compare
nicklasl
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-posting the latest OF events/state proposal here, for reference:
The transition introduced in the PR is allowed:
I am not particularly fond of adding a short ERROR state before moving to READY, just so we can emit the ERROR event for the user to observe. I wonder if we could add some WARNING or LOG event type in the OF layer, that doesn't cause state transitions but allows to communicate internals to the user.
However, this could be a stop-gap solution for now