This repository has been archived by the owner on Oct 1, 2020. It is now read-only.
expose zookeeper configuration and kafka zookeeper.connect for proper clustering #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
| @@ -41,6 +49,11 @@ if [ ! -z "$ZK_CHROOT" ]; then | |||
| sed -r -i "s/(zookeeper.connect)=(.*)/\1=localhost:2181\/$ZK_CHROOT/g" $KAFKA_HOME/config/server.properties | |||
| fi | |||
|
|
|||
| if [ ! -z $ZOOKEEPER_SERVERS ]; then | |||
| # TODO: ZOOKEEPER_SERVERS incompatible with ZK_CHROOT | |||
| sed -r -i "s/(zookeeper.connect)=(.*)/${ZOOKEEPER_SERVERS}/g" $KAFKA_HOME/config/server.properties | |||
There was a problem hiding this comment.
This should be sed -r -i "s/(zookeeper.connect)=(.*)/\1=${ZOOKEEPER_SERVERS}/g" $KAFKA_HOME/config/server.properties
Or it is replacing the full match, not just the second group.
Relevant pull request: #65. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Love the image for development, but would like to expand it into a full blown production-ready image! I know we're a bit of distance away from that, but figured I'd rather contribute with you fine folks than to set out alone.
What I've done is expose the zookeeper configuration file by wrapping it in a start-zookeeper.sh (much like your start-kafka.sh) which reads in environment values and sets the configuration. It also allows the "zookeeper.connect" flag to be set in Kafka's configuration. I also moved the KAFKA_HOME environment variable into that script and merged the ENV docker layers.
I'll be continuing to work on this branch, so feel free to leave unmerged until I can add some documentation and actually test it across multiple hosts :)
Any thoughts about how I've handled ZK's configuration are welcome - I hesitate to do differently than the start-kafka.sh style, but I didn't want to write out every single possible ZK config option either. This feels like an OK middle ground to me, especially considering the very small number of default options ZK has.
Anyways, thanks again!