Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Issue Comment Reaction functionality #215

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

Abhi347
Copy link
Member

@Abhi347 Abhi347 commented Feb 19, 2025

Adds the functionality to react on issue comments with emojis. This PR also includes listing and deleting those reactions for a particular comment.

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.71%. Comparing base (c4a4e64) to head (74eeb70).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ub/jackson/CommentReactionContentDeserializer.java 66.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #215      +/-   ##
============================================
+ Coverage     77.24%   77.71%   +0.47%     
- Complexity      338      349      +11     
============================================
  Files            47       50       +3     
  Lines          1116     1149      +33     
  Branches         44       46       +2     
============================================
+ Hits            862      893      +31     
- Misses          225      226       +1     
- Partials         29       30       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Abhi347 Abhi347 force-pushed the feat/add-comment-reaction branch from 30abc05 to 377eb0e Compare February 19, 2025 16:12
@Abhi347 Abhi347 force-pushed the feat/add-comment-reaction branch 3 times, most recently from ae912d7 to 7a10ca3 Compare February 24, 2025 10:42
@Abhi347 Abhi347 marked this pull request as ready for review February 24, 2025 10:45
@Abhi347 Abhi347 force-pushed the feat/add-comment-reaction branch from 7a10ca3 to 74eeb70 Compare February 24, 2025 12:52
@@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>

<artifactId>github-client</artifactId>
<version>0.4.1-SNAPSHOT</version>
<version>0.3.7-SNAPSHOT</version>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

going backwards?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was an error so I decided to fix it in this PR too to not publish the wrong version.
Here's more detail about the issue - #214

@Abhi347 Abhi347 merged commit 56337cf into master Feb 25, 2025
5 checks passed
@Abhi347 Abhi347 deleted the feat/add-comment-reaction branch February 25, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants