This repository has been archived by the owner on Sep 12, 2024. It is now read-only.
Fix errors when building with JDK11 #1240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
davidxia
commented
Oct 6, 2018
davidxia
commented
- Upgrade various plugins whose old versions don't work on JDK11.
- Upgrade com.spotify:foss-root pom from 5 to 9.
- Fix various checkstyle and Javadoc errors resulting from upgrades of above.
* Upgrade various plugins whose old versions don't work on JDK11. * Upgrade com.spotify:foss-root pom from 5 to 9. * Fix various checkstyle and Javadoc errors resulting from upgrades of above.
Codecov Report
@@ Coverage Diff @@
## master #1240 +/- ##
============================================
+ Coverage 52.75% 52.82% +0.06%
- Complexity 1625 1626 +1
============================================
Files 268 268
Lines 13061 13057 -4
Branches 1508 1505 -3
============================================
+ Hits 6890 6897 +7
+ Misses 5647 5638 -9
+ Partials 524 522 -2 |
|
I suggest combining this with #1242, so that the CI can tell us if these are all the changes that are needed or not. Does Circle support a build matrix like Travis? |
|
It does. I've moved this commit to #1242. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.