This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Add "place" and "coordinates" to Tweet class #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StreamReaderImpl creates a pool of threads which isn't cleared after close. It leads to serious problems after hundreds open()/close() cycles.
|
Before I can merge this request, I need to confirm that you've reviewed and agreed to the individual committer license agreement at https://support.springsource.com/spring_committer_signup. |
|
Closing and immediately reopening, hoping to trigger Travis CI against this PR. |
|
@ukyovirgden Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented deserializing of geolocation information from twitter responses and added "place" and "coordinates" to Tweet class.
Changes are kept minimal and I've avoided using deprecated classes. A class named Coordinates were implemented alongside with its JsonMixin and Deserializer, An attribute of type coordinates were added to Tweet.
Changed the behavior of "boundingbox" property to support the latest changes in Twitter API. boundingbox were a list of points, corrected it to be the type of Geometry
Added place attribute to Tweet class and wired necessary deserialization.
Added necessary tests