This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Enabling multi-domain callback support and override of the callbackUrl method #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Alexander! We are having the same issue you had with multi-domains. One question: what if you need a Facebook/Twitter app for each domain? FacebookConnectionFactory and TwitterConnectionFactory receive the app keys on construction, so they should be changed to resolve the keys to use depending on the requested URL. Did you have this problem? |
bclozel
added a commit
that referenced
this pull request
Oct 29, 2014
Fix directory name for sample pages
|
@alexander-codebase Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on forum, submitting the changes related to enabling multi-domain callback support and override of the callbackUrl method. Changes should not affect original functionality if an absolute URL is used as applicationUrl for the bean, but they allow callback URLs to be formed depending on the current domain name if the relative URL has been used instead.
http://forum.springsource.org/showthread.php?109571-Callbacks-and-multihomed-hosts