Added support for Redis as a backing datastore for social connections #198
Conversation
|
👍 |
|
👍 Nice one |
Added unit tests running on local redis Unit tests will be skipped if redis is not found through the use of JUnit rules Fixed a bug when finding social connections by providerUserId - field was not Indexed in Redis Implemented and tested RedisUsersConnectionRepository
|
@mp911de / @christophstrobl — Might be worth a glance, too. Just to double check the obvious. :) |
|
|
||
| SocialRedisConnection findOneByUserIdAndProviderIdAndProviderUserId(String userId, String providerId, String providerUserId); | ||
|
|
||
| void deleteByUserIdAndProviderIdAndProviderUserId(final String userId, final String providerId, final String providerUserId); |
There was a problem hiding this comment.
Derived delete…By… methods are not yet supported by Redis Repositories, see DATAKV-135 which is the pre-requisite. Entities can be deleted directly using the Repository.delete(…) method or RedisKeyValueAdapter.delete(…).
There was a problem hiding this comment.
Cool, thanks for looking at it, I will make the adjustments, add unit tests and update the dependency version from 1.7.0.RC1 to 1.7.1.RELEASE
Updated spring-data-redis version to 1.7.1.RELEASE Added RedisHash keyspace for server side queries in case of Redis Cluster Updated delete method Added unit tests
|
This looks interesting and something I might merge. If you have not done so yet, please sign the Individual Contributor Agreement at https://support.springsource.com/spring_committer_signup. |
|
I've signed the (new) agreement, thanks for looking into this! |
|
Closing PR and then will immediately reopen, in hopes of triggering Travis CI. |
|
Cool, thanks @habuma ! |
This is my first commit for the Redis backed datastore for social connections. It uses the
1.7.0.RC1release ofspring-data-rediswhich enables support for Redis repositories. Maybe we should wait forspring-data-redis-1.7.0.RELEASEbut I wanted to get it out there asap 👶There are still some unit tests to be performed and I need to implement one final method of the, namely:
Also, I'm still not sure about the names of my classes, could someone maybe recommend more suitable names?
Thank you for commenting/contributing/improving my code 😋