This repository has been archived by the owner on Apr 5, 2022. It is now read-only.
Make ConnectController and ProviderSignInController more extendable #35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be really useful to be able to extend ConnectController and ProviderSignInController to add custom callback methods. For example, the callbacks from LastFm's api are neither OAuth1 or OAuth2 but are similar (using a different request parameter name). Adding new callback methods means requiring much of the functionality of the existing callback methods, but the existing callback methods use private helper methods and attributes. Making the visibility of these helper methods and attributes protected rather than private would make extending these controllers easier.
See
https://github.com/michaellavelle/spring-social-lastfm-non-oauth-web/blob/master/src/main/java/org/springframework/social/lastfm/nonoauth/connect/web/LastFmNonOAuthSignInController.java
for an example of this use case.
This controller extends a custom controller class
https://github.com/socialsignin/spring-social-web-non-oauth-extension/blob/master/src/main/java/org/springframework/social/connect/web/ExtensibleProviderSignInController.java
but could simply extend the existing ProviderSignInController if these visibility modifications were made.