Add property to disable adding invalid prefix when decryption fails #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spring-cloud#2632 Signed-off-by: Ryan Baxter <[email protected]>
ryanjbaxter
force-pushed
the
disable-invalid-prefix-property
branch
from
4008707 to
8ceab26
Compare
ryanjbaxter
commented
Jan 15, 2025
| @@ -44,6 +45,9 @@ | |||
| @AutoConfigureAfter(DefaultTextEncryptionAutoConfiguration.class) | |||
| public class EncryptionAutoConfiguration { | |||
|
|
|||
| @Value("${spring.cloud.config.server.encrypt.prefixInvalidProperties:${spring.cloud.config.server.encrypt.prefix-invalid-properties:true}}") | |||
There was a problem hiding this comment.
I did not like doing it this way but if I were to initialize ConfigServerProperties in this class it would cause some issues when the config server uses bootstrap. It looks like certain properties do not get initialized properly and promoted to the main context. This was the lest amount of disruptive changes to make this work.
spencergibb
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2632