Support multiple task listener beans of same type #796
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
In a Spring Cloud Task application, when I have more than one beans of task listeners with @BeforeTask, @AfterTask and/or @FailedTask of same type (or different types inheriting the same @BeforeTask/@AfterTask/@FailedTask method), only single one of those listener beans work. Listener methods of the rest of the beans are never invoked. Please see the following example.
I don't know if this is the intended behaviour but this is an unexpected behaviour to me and not documented AFAIK. This behaviour also causes multi-step partitioned tasks to fail with NPE since DeployerPartitionHandler uses @BeforeTask to inject TaskExecution. (See #793)
This PR changes this behaviour so that all listener methods are invoked even the listener beans have the same type (or different types inheriting the same listener method) I've added some unit tests as well to cover "multiple listener beans of same type" case. I've also tested these changes with a multi-step partitioned task and it just seemed to work fine.
Thanks.