Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ivy version to 2.5.2 #619

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Conversation

onobc
Copy link
Collaborator

@onobc onobc commented Jan 23, 2025

Updates org.apache.ivy:ivy to version 2.5.2 to fix CVE-2022-46751

@onobc onobc added the dependencies Pull requests that update a dependency file label Jan 23, 2025
@onobc onobc added this to the 2025.0.0 milestone Jan 23, 2025
@onobc onobc marked this pull request as draft January 24, 2025 00:11
onobc added 2 commits January 23, 2025 19:13
Updates `org.apache.ivy:ivy` to version 2.5.2 to fix
CVE-2022-46751
Adds 2 CVEs due to `debezium-supplier` transitive dependencies.
@onobc onobc force-pushed the update-ivy-version-2_5_2 branch from 122b10e to a289835 Compare January 24, 2025 01:14
@@ -14,10 +14,6 @@
<relativePath>../../stream-applications-core/pom.xml</relativePath>
</parent>

<properties>
<apache-ivy.version>2.5.1</apache-ivy.version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, Chris, how does it work if we don’t specify version any more?
Is this Spring Boot managed dep?
So, it comes as latest now and with all those CVEs fixed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @artembilan - I was not clear in my description. We (stream-applications) already have dep. mgmt. for this ivy in stream-applications-build but for some reason these versions were still being hardcoded in these modules.
This moves those versions out of the way and lets the stream-applications-build/pom.xml be the final arbiter of the versions.

################################
## From debezium-supplier
################################
CVE-2023-1428
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These "mute" the grpc and protobuf related CVEs being reported

@@ -4,7 +4,6 @@ SCDIR=$(realpath $SCDIR)
if [[ "$1" != *"-sources.jar" ]] && [[ "$1" != *"-javadoc.jar" ]]; then
if [ "$TRIVY_UPLOAD" == "true" ]; then
echo "Scanning:$1"
echo "trivy rootfs --format sarif -o \"$1.sarif\" \"$1\""
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like some debug that is surely to get out of sync w/ the actual command

@onobc onobc marked this pull request as ready for review January 24, 2025 04:23
@onobc
Copy link
Collaborator Author

onobc commented Jan 24, 2025

@artembilan I am going to go ahead and merge this. I am happy to make any changes post merge.

@onobc onobc merged commit 6cc9cdd into spring-cloud:main Jan 24, 2025
2 checks passed
@onobc onobc deleted the update-ivy-version-2_5_2 branch January 24, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants