Remove method call without effect (#128)

* Remove method call without effect Since id is @GeneratedValue setId() wouldn't do anything
spring-guides · Jun 7, 2024 · f16f146 · f16f146
1 parent 083b30a
commit f16f146
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 4 deletions.
diff --git a/evolution/src/main/java/payroll/EmployeeController.java b/evolution/src/main/java/payroll/EmployeeController.java
@@ -82,7 +82,6 @@ ResponseEntity<?> replaceEmployee(@RequestBody Employee newEmployee, @PathVariab
 					return repository.save(employee);
 				}) //
 				.orElseGet(() -> {
-					newEmployee.setId(id);
 					return repository.save(newEmployee);
 				});
 

diff --git a/links/src/main/java/payroll/EmployeeController.java b/links/src/main/java/payroll/EmployeeController.java
@@ -76,7 +76,6 @@ ResponseEntity<?> replaceEmployee(@RequestBody Employee newEmployee, @PathVariab
 					return repository.save(employee);
 				}) //
 				.orElseGet(() -> {
-					newEmployee.setId(id);
 					return repository.save(newEmployee);
 				});
 

diff --git a/nonrest/src/main/java/payroll/EmployeeController.java b/nonrest/src/main/java/payroll/EmployeeController.java
@@ -52,7 +52,6 @@ Employee replaceEmployee(@RequestBody Employee newEmployee, @PathVariable Long i
 				return repository.save(employee);
 			})
 			.orElseGet(() -> {
-				newEmployee.setId(id);
 				return repository.save(newEmployee);
 			});
 	}

diff --git a/rest/src/main/java/payroll/EmployeeController.java b/rest/src/main/java/payroll/EmployeeController.java
@@ -73,7 +73,6 @@ Employee replaceEmployee(@RequestBody Employee newEmployee, @PathVariable Long i
 					return repository.save(employee);
 				}) //
 				.orElseGet(() -> {
-					newEmployee.setId(id);
 					return repository.save(newEmployee);
 				});
 	}