Possible fix for issue #2218, allowing to disable setting the Authorization header #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the Authorization header. Signed-off-by: pbakker <[email protected]>
ilayaperumalg
approved these changes
Feb 12, 2025
| import org.springframework.ai.model.ChatModelDescription; | ||
| import org.springframework.ai.model.ModelOptionsUtils; | ||
| import org.springframework.ai.model.SimpleApiKey; | ||
| import org.springframework.ai.model.*; |
There was a problem hiding this comment.
wildcard import isn't allowed and will fix when merging.
|
@paulbakker Thanks for the PR! |
|
PR to use ApiKey for other OpenAI APIs: #2226 |
|
Thanks for the super quick follow up @ilayaperumalg 🙏 |
markpollack
reviewed
Feb 18, 2025
| @@ -200,7 +192,10 @@ public OpenAiApi(String baseUrl, ApiKey apiKey, MultiValueMap<String, String> he | |||
| this.embeddingsPath = embeddingsPath; | |||
| // @formatter:off | |||
| Consumer<HttpHeaders> finalHeaders = h -> { | |||
| h.setBearerAuth(apiKey.getValue()); | |||
| if(!(apiKey instanceof NoopApiKey)) { | |||
There was a problem hiding this comment.
instead of checking for a specific impl, we should check for the return value, if it is empty then don't set header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow disabling setting the Authorization header in OpenAi models.
Possible fix for #2218