-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RabbitTemplate getBeforePublishPostProcessors method #2839
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot approve this change without any reasoning.
Share with us, please, your experience why would one get access to this property?
The Justification:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. All those arguments still don't convince me in the importance of this API since all the objects you are going to inject/retrieve from there are already somewhere in your configuration.
Apparently what you are going to be is to get them, modify and set back. So, why just not have a set of those post-processors somewhere outside of RabbitTemplate
and set them (or override) respectively whenever you need?
Nevertheless since this new API is totally not harmful, I'll accept the change and merge it shortly.
|
||
/** | ||
* Return configured before post {@link MessagePostProcessor}s or {@code null}. | ||
* @return configured before post {@link MessagePostProcessor}s or {@code null}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, add @since 3.2
and your name to the @author
list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also see Checkstyle violations:
Error: eckstyle] [ERROR] /home/runner/work/spring-amqp/spring-amqp/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/core/RabbitTemplate.java:635: Line matches the illegal pattern 'Trailing whitespace'. [Regexp]
Run ./gradlew clean check
locally.
No description provided.