-
Notifications
You must be signed in to change notification settings - Fork 40.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft interface clients autoconfiguration #42003
base: main
Are you sure you want to change the base?
Draft interface clients autoconfiguration #42003
Conversation
9ad2104
to
ad87582
Compare
Possible integrations to consider adding in other projects later on:
|
@Target(ElementType.TYPE) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@Documented | ||
public @interface HttpClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving over to Framework.
@Target(ElementType.TYPE) | ||
@Retention(RetentionPolicy.RUNTIME) | ||
@Documented | ||
public @interface RSocketClient { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider moving over to Framework.
Setting |
We still have 3.4.0-M3 in September an RC1 in October so 3.4.0 remains a possibility. If we don't manage that, it'd have to wait until a 3.5 milestone as we really try not to ship enhancements in maintenance releases. |
3902eca
to
8326022
Compare
Hey @OlgaMaciaszek , would you consider accepting community contributions for these autoconfigurations? It would be really nice to have this in 3.5 and me and @radoslaw-panuszewski are willing to help 🙂 |
@aleksandrserbin @radoslaw-panuszewski thanks a lot for reaching out. We've decided to change our approach by moving some of the implementation to Framework and, hence, move it all to after next Framework release (and that was the reason we've moved it to Boot 4.0); we are now actively working on it and a new PR will be submitted shortly, based some additional building blocks created for Framework, so this is probably one of the cases where it would not make much sense to request community PR as we have the changes in the works already as we speak. |
I see, it makes sense, thank you! |
Related sample repo: https://github.com/OlgaMaciaszek/demo-interfaceclients-autoconfig
Fixes gh-31337