Revert "Properly render sort variable variable as composite."

This reverts commit 40edfdf as the change has too many side effects to be included in a bugfix version. Related ticket: GH-2531.
spring-projects · Dec 12, 2023 · 3e0ab7a · 3e0ab7a
1 parent 02fccfe
commit 3e0ab7a
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 13 deletions.
diff --git a/src/main/java/org/springframework/data/web/HateoasSortHandlerMethodArgumentResolver.java b/src/main/java/org/springframework/data/web/HateoasSortHandlerMethodArgumentResolver.java
@@ -35,7 +35,6 @@
  * @author Oliver Gierke
  * @author Thomas Darimont
  * @author Nick Williams
- * @author Julien Béti
  */
 public class HateoasSortHandlerMethodArgumentResolver extends SortHandlerMethodArgumentResolver
 		implements UriComponentsContributor {
@@ -59,7 +58,7 @@ public TemplateVariables getSortTemplateVariables(MethodParameter parameter, Uri
 
 		String description = String.format("pagination.%s.description", sortParameter);
 		TemplateVariable.VariableType type = append ? REQUEST_PARAM_CONTINUED : REQUEST_PARAM;
-		return new TemplateVariables(new TemplateVariable(sortParameter, type, description).composite());
+		return new TemplateVariables(new TemplateVariable(sortParameter, type, description));
 	}
 
 	@Override

diff --git a/...a/org/springframework/data/web/HateoasPageableHandlerMethodArgumentResolverUnitTests.java b/...a/org/springframework/data/web/HateoasPageableHandlerMethodArgumentResolverUnitTests.java
@@ -29,7 +29,6 @@
  * Unit tests for {@link HateoasPageableHandlerMethodArgumentResolver}.
  *
  * @author Oliver Gierke
- * @author Julien Béti
  */
 class HateoasPageableHandlerMethodArgumentResolverUnitTests
 		extends PageableHandlerMethodArgumentResolverUnitTests {
@@ -68,18 +67,18 @@ void preventsPageSizeFromExceedingMayValueIfConfiguredOnWrite() throws Exception
 		assertUriStringFor(PageRequest.of(0, 200), "page=0&size=100");
 	}
 
-	@Test // DATACMNS-418, GH-2531
+	@Test // DATACMNS-418
 	void appendsTemplateVariablesCorrectly() {
 
-		assertTemplateEnrichment("/foo", "{?page,size,sort*}");
-		assertTemplateEnrichment("/foo?bar=1", "{&page,size,sort*}");
-		assertTemplateEnrichment("/foo?page=1", "{&size,sort*}");
-		assertTemplateEnrichment("/foo?page=1&size=10", "{&sort*}");
+		assertTemplateEnrichment("/foo", "{?page,size,sort}");
+		assertTemplateEnrichment("/foo?bar=1", "{&page,size,sort}");
+		assertTemplateEnrichment("/foo?page=1", "{&size,sort}");
+		assertTemplateEnrichment("/foo?page=1&size=10", "{&sort}");
 		assertTemplateEnrichment("/foo?page=1&sort=foo,asc", "{&size}");
 		assertTemplateEnrichment("/foo?page=1&size=10&sort=foo,asc", "");
 	}
 
-	@Test // DATACMNS-418, GH-2531
+	@Test // DATACMNS-418
 	void returnsCustomizedTemplateVariables() {
 
 		var uriComponents = UriComponentsBuilder.fromPath("/foo").build();
@@ -88,7 +87,7 @@ void returnsCustomizedTemplateVariables() {
 		resolver.setPageParameterName("foo");
 		var variables = resolver.getPaginationTemplateVariables(null, uriComponents).toString();
 
-		assertThat(variables).isEqualTo("{?foo,size,sort*}");
+		assertThat(variables).isEqualTo("{?foo,size,sort}");
 	}
 
 	@Test // DATACMNS-563

diff --git a/.../java/org/springframework/data/web/HateoasSortHandlerMethodArgumentResolverUnitTests.java b/.../java/org/springframework/data/web/HateoasSortHandlerMethodArgumentResolverUnitTests.java
@@ -29,7 +29,6 @@
  * Unit tests for {@link HateoasSortHandlerMethodArgumentResolver}
  *
  * @author Oliver Gierke
- * @author Julien Béti
  */
 class HateoasSortHandlerMethodArgumentResolverUnitTests extends SortHandlerMethodArgumentResolverUnitTests {
 
@@ -48,13 +47,13 @@ void replacesExistingRequestParameters() throws Exception {
 		assertUriStringFor(SORT, "/?sort=firstname,lastname,desc", "/?sort=foo,asc");
 	}
 
-	@Test // DATACMNS-418, GH-2531
+	@Test // DATACMNS-418
 	void returnCorrectTemplateVariables() {
 
 		var uriComponents = UriComponentsBuilder.fromPath("/").build();
 
 		var resolver = new HateoasSortHandlerMethodArgumentResolver();
-		assertThat(resolver.getSortTemplateVariables(null, uriComponents).toString()).isEqualTo("{?sort*}");
+		assertThat(resolver.getSortTemplateVariables(null, uriComponents).toString()).isEqualTo("{?sort}");
 	}
 
 	private void assertUriStringFor(Sort sort, String expected) throws Exception {