Provide invocation arguments for RepositoryMethodInvocation #2681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
roookeee
commented
Aug 26, 2022
| @@ -56,7 +56,7 @@ public void notifyListeners(Method method, Object[] args, RepositoryMethodInvoca | |||
|
|
|||
| /** | |||
| * {@link RepositoryInvocationMulticaster} implementation that notifies {@link RepositoryMethodInvocationListener} | |||
| * upon {@link #notifyListeners(Method, Object[], RepositoryMethodInvocationResult)}. | |||
There was a problem hiding this comment.
I just fixed this broken JavaDoc which I noticed along the way, it's not directly related to this pr.
|
I put the new |
roookeee
commented
Aug 26, 2022
| @@ -197,6 +197,7 @@ void capturesImperativeSuccessCorrectly() throws Exception { | |||
|
|
|||
| assertThat(multicaster.first().getResult().getState()).isEqualTo(State.SUCCESS); | |||
| assertThat(multicaster.first().getResult().getError()).isNull(); | |||
| assertThat(multicaster.first().getArguments()).isNotNull(); | |||
There was a problem hiding this comment.
I felt like its appropriate to check all state case results should have arguments present, any thoughts on this? I could make this a more explicit check if you want.
christophstrobl
added
type: enhancement
odrotbohm
force-pushed
the
main
branch
2 times, most recently
from
fe5e80e
to
98f20a4
Compare
mp911de
force-pushed
the
main
branch
2 times, most recently
from
0122d1b
to
5070a0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2677 for more information about this PR.