Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-4873: configurable Document.toJson() serialization for logging #4915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rfelgent
Copy link
Contributor

@rfelgent rfelgent commented Mar 8, 2025

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 8, 2025
@rfelgent
Copy link
Contributor Author

rfelgent commented Mar 8, 2025

Hi @mp911de ,

after looking into the code, I would like to discuss options with you.

  1. introduce XXXDelegate class for logging serialization (with refactoring of MongoTemplate/ReactiveMongoTemplate)
  2. add SerializationUtils#serializeToJsonSafely(@Nullable Document document, JsonWriterSettings settings) {} (with refactoring of MongoTemplate/ReactiveMongoTemplate)
  3. introduce a Log-EntityCallback to log Document before persisting it to data base (no refactoring of MongoTemplate/ReactiveMongoTemplate). This will not work for "query()" logs, will it ? Is it a valid requirement ?
  4. shouldn't the mongodb-driver itself provide this logging functionality (json and bson) ?

If we want to put hands on it, my preference is option 3) otherwise option 4). What dou you think ?

Furthermore, is there another way to discuss ideas and implementation details with you apart form comments in pull requests ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting-for-triage An issue we've not yet triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants