Skip to content

Commit

Permalink
Remove CglibMethodInvocation
Browse files Browse the repository at this point in the history
This class does not add anything anymore and can be
replaced by a plain ReflectiveMethodInvocation.

Closes gh-33585
  • Loading branch information
sdeleuze committed Oct 3, 2024
1 parent eebaa35 commit d65bdce
Showing 1 changed file with 3 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -672,8 +672,8 @@ public FixedChainStaticTargetInterceptor(
@Override
@Nullable
public Object intercept(Object proxy, Method method, Object[] args, MethodProxy methodProxy) throws Throwable {
MethodInvocation invocation = new CglibMethodInvocation(
proxy, this.target, method, args, this.targetClass, this.adviceChain, methodProxy);
MethodInvocation invocation = new ReflectiveMethodInvocation(
proxy, this.target, method, args, this.targetClass, this.adviceChain);
// If we get here, we need to create a MethodInvocation.
Object retVal = invocation.proceed();
retVal = processReturnType(proxy, this.target, method, args, retVal);
Expand Down Expand Up @@ -724,7 +724,7 @@ public Object intercept(Object proxy, Method method, Object[] args, MethodProxy
}
else {
// We need to create a method invocation...
retVal = new CglibMethodInvocation(proxy, target, method, args, targetClass, chain, methodProxy).proceed();
retVal = new ReflectiveMethodInvocation(proxy, target, method, args, targetClass, chain).proceed();
}
return processReturnType(proxy, target, method, args, retVal);
}
Expand Down Expand Up @@ -756,26 +756,6 @@ public int hashCode() {
}


/**
* Implementation of AOP Alliance MethodInvocation used by this AOP proxy.
*/
private static class CglibMethodInvocation extends ReflectiveMethodInvocation {

public CglibMethodInvocation(Object proxy, @Nullable Object target, Method method,
Object[] arguments, @Nullable Class<?> targetClass,
List<Object> interceptorsAndDynamicMethodMatchers, MethodProxy methodProxy) {

super(proxy, target, method, arguments, targetClass, interceptorsAndDynamicMethodMatchers);
}

@Override
@Nullable
public Object proceed() throws Throwable {
return super.proceed();
}
}


/**
* CallbackFilter to assign Callbacks to methods.
*/
Expand Down

0 comments on commit d65bdce

Please sign in to comment.