-
Notifications
You must be signed in to change notification settings - Fork 38.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support decoding empty DataBuffers for Decoders that support it #29903
base: main
Are you sure you want to change the base?
Commits on Jan 30, 2023
-
Support decoding empty DataBuffers for Decoders that support it
Some decoders support decoding a proper payload from empty DataBuffers. One good example is the ProtobufDecoder. This patch adds a method canDecodeEmptyDataBuffer() to the Decoder interface, allowing the Decoder to signal that it is able to do that. In this case, the PayloadMethodArgumentResolver should pass the empty DataBuffer to the Decoder, and in all other cases behave like before.
Configuration menu - View commit details
-
Copy full SHA for a40b549 - Browse repository at this point
Copy the full SHA a40b549View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd06e77 - Browse repository at this point
Copy the full SHA dd06e77View commit details
Commits on Feb 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c808ba7 - Browse repository at this point
Copy the full SHA c808ba7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4482ea1 - Browse repository at this point
Copy the full SHA 4482ea1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c29c515 - Browse repository at this point
Copy the full SHA c29c515View commit details -
Fix failing test in spring-messaging
The `filterNonEmptyDataBuffer()` method was added via the fix for spring-projectsgh-26344. The comment states that this fix was done because for some Decoders, an empty input may not yield a valid message. Since this is now fixed by asking the decoder whether it can decode an empty DataBuffer, the test is now able to yield a value from empty input.
Configuration menu - View commit details
-
Copy full SHA for a29f557 - Browse repository at this point
Copy the full SHA a29f557View commit details
Commits on Feb 8, 2023
-
rename canDecodeEmptyDataBuffer to canDecodeEmptyMessage, to better r…
…eflect that its only meant for complete messages
Configuration menu - View commit details
-
Copy full SHA for 4ece71d - Browse repository at this point
Copy the full SHA 4ece71dView commit details -
improve testDecodeToMonoEmptyMessage() to use 2 empty source buffers,…
… to better reflect the usecase
Configuration menu - View commit details
-
Copy full SHA for 0d03e2c - Browse repository at this point
Copy the full SHA 0d03e2cView commit details