YamlPropertiesFactoryBean incorrect flatten nested map to properties #34285
+62
−14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix issue #27020.
For the method
org.springframework.beans.factory.config.YamlProcessor#getFlattenedMap
before this PR:[
, will returnpath + key
as map key.path + '.' + key
as map key.For the method
org.springframework.beans.factory.config.YamlProcessor#getFlattenedMap
after this PR:[
or end with]
, will returnpath + '[' + key + ']'
as map key.path + '.' + key
as map key.Collection
like[0]
, will returnpath + key
as map key.For the method
org.springframework.beans.factory.config.YamlProcessor#asMap
after this PR:Change
result.put("[" + key.toString() + "]", value);
toresult.put(key.toString(), value);
onasMap
.And the test case you can see:
By the way,
org.springframework.beans.factory.config.YamlMapFactoryBean#getObject
result is: