Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for graphql sample #316

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dmfrey
Copy link
Contributor

@dmfrey dmfrey commented Feb 18, 2022

No description provided.

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GraphqlApplication is missing in this commit...
Probably better to extract that config from the test into the main app.
And use that main app in the test configuration already. The @SpringBootTest should do the trick for us.

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@dmfrey
Copy link
Contributor Author

dmfrey commented Feb 19, 2022

The GraphqlApplication is missing in this commit... Probably better to extract that config from the test into the main app. And use that main app in the test configuration already. The @SpringBootTest should do the trick for us.

@artembilan this wasn't needed. I forgot to revert it to what it was previously. That will be addressed in the next commit.

project('graphql') {
description = 'GraphQL Sample'

apply plugin: 'application'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you take away Spring Boot plugin?
That one one take care for reactor dependencies and so on.


apply plugin: 'application'

mainClassName = 'org.springframework.integration.samples.graphql.Main'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no such a class in your change...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants