Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-3555: Improve docs for KafkaHeaders.CONVERSION_FAILURES #3611

Merged
merged 2 commits into from
Nov 11, 2024
Merged

GH-3555: Improve docs for KafkaHeaders.CONVERSION_FAILURES #3611

merged 2 commits into from
Nov 11, 2024

Commits on Nov 1, 2024

  1. spring-projectsGH-3555: Improve docs for `KafkaHeaders.CONVERSION_FAI… 

    …LURES`

Fixes: spring-projects#3555
Issue link: spring-projects#3555

The batch might be processed in the `@KafkaListener` silently without looking into conversion failures header.
So, that might cause in impression that nothing is wrong with the batch.

* Mention `KafkaHeaders.CONVERSION_FAILURES` in the docs
* Add `warn` for the failed conversion in the `BatchMessagingMessageConverter`
* Some other code optimization clean up in the `BatchMessagingMessageConverter`
    @artembilan
    artembilan committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    4b8e8a4 View commit details
    Browse the repository at this point in the history

  2. Fix Checkstyle violations

    @artembilan
    artembilan committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    3b7cf6c View commit details
    Browse the repository at this point in the history