Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functions TypeRegistry.shutdownFileSystemWatcherThread and FileSystemWatcher.shutdownAndWait #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akhikhl
Copy link

@akhikhl akhikhl commented Jun 18, 2014

Context

I integrate springloaded and embedded tomcat in gretty gradle plugin.

Problem

When stopping/restarting webapp under embedded tomcat with springloaded agent, tomcat issues warning:

The web application [/xyz] appears to have started a thread named [FileSystemWatcher: files=#1 cl=java.net.URLClassLoader@777d673c] 
but has failed to stop it. This is very likely to create a memory leak.

The warning is apparently related to the fact that FileSystemWatcher thread is still running, even when related classloader goes out of scope (as by webapp stop/restart),

Solution

I need the new function TypeRegistry.shutdownFileSystemWatcherThread in order to deterministically shut down springloaded threads before webapp is stopped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant