Skip to content

Commit

Permalink
Remove commons-logging excludes
Browse files Browse the repository at this point in the history
The spring-jcl module has been removed in Spring Framework 7 in
favor of Commons Logging 1.3. This commit removes the excludes
for commons-logging:commons-logging that werew required to ensure
that spring-jcl was used instead but that are no longer needed.

See gh-955
  • Loading branch information
wilkinsona committed Feb 3, 2025
1 parent 0b103fd commit 8fd536c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
4 changes: 1 addition & 3 deletions spring-restdocs-asciidoctor/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ dependencies {
internal(platform(project(":spring-restdocs-platform")))

testImplementation("junit:junit")
testImplementation("org.apache.pdfbox:pdfbox") {
exclude group: "commons-logging", module: "commons-logging"
}
testImplementation("org.apache.pdfbox:pdfbox")
testImplementation("org.assertj:assertj-core")
testImplementation("org.springframework:spring-core")

Expand Down
4 changes: 1 addition & 3 deletions spring-restdocs-restassured/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ description = "Spring REST Docs REST Assured"

dependencies {
api(project(":spring-restdocs-core"))
api("io.rest-assured:rest-assured") {
exclude group: "commons-logging", module: "commons-logging"
}
api("io.rest-assured:rest-assured")
implementation("org.springframework:spring-web")

internal(platform(project(":spring-restdocs-platform")))
Expand Down

0 comments on commit 8fd536c

Please sign in to comment.